Re: [PATCH -next RESEND] regulator: BD71815: select REGULATOR_ROHM to fix link errors

From: Matti Vaittinen
Date: Tue Apr 27 2021 - 00:22:47 EST


Morning Randy,

On Mon, 2021-04-26 at 11:37 -0700, Randy Dunlap wrote:
> With REGULATOR_ROHM there are linker errors:
>
> ld: drivers/regulator/bd71815-regulator.o: in function
> `set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0xbb): undefined reference to
> `rohm_regulator_set_dvs_levels'
> ld: drivers/regulator/bd71815-regulator.o: in function
> `buck12_set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0x33e): undefined reference to
> `rohm_regulator_set_dvs_levels'
>
> Fixes: 1aad39001e851 ("regulator: Support ROHM BD71815 regulators")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> ---
> Sorry about the Resend. I'm having some email problems.

Thanks for fixing this. I just wanted to let you know Arnd sent same
fix (and couple of other fixes to BD71815) few days ago. Mark couldn't
take the patches as the original series is only in Lee's tree. Sorry
for causing the problems.

Best Regards
Matti Vaittinen