RE: [net-next, v2, 3/7] net: dsa: free skb->cb usage in core driver

[Y.b. Lu]

> -----Original Message-----
> From: Richard Cochran <richardcochran@xxxxxxxxx>
> Sent: 2021年4月26日 21:39
> To: Y.b. Lu <yangbo.lu@xxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; Vladimir Oltean <vladimir.oltean@xxxxxxx>;
> David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Jonathan Corbet <corbet@xxxxxxx>; Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>;
> Andrew Lunn <andrew@xxxxxxx>; Vivien Didelot <vivien.didelot@xxxxxxxxx>;
> Florian Fainelli <f.fainelli@xxxxxxxxx>; Claudiu Manoil
> <claudiu.manoil@xxxxxxx>; Alexandre Belloni
> <alexandre.belloni@xxxxxxxxxxx>; UNGLinuxDriver@xxxxxxxxxxxxx;
> linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [net-next, v2, 3/7] net: dsa: free skb->cb usage in core driver
> 
> On Mon, Apr 26, 2021 at 05:37:58PM +0800, Yangbo Lu wrote:
> > @@ -624,7 +623,7 @@ static netdev_tx_t dsa_slave_xmit(struct sk_buff
> *skb, struct net_device *dev)
> >
> >  	dev_sw_netstats_tx_add(dev, 1, skb->len);
> >
> > -	DSA_SKB_CB(skb)->clone = NULL;
> > +	memset(skb->cb, 0, 48);
> 
> Replace hard coded 48 with sizeof() please.

Fixed in v3.
Thank you!

> 
> Thanks,
> Richard