Re: [PATCH] firmware: arm_scmi: Remove repeated struct declaration

From: Cristian Marussi
Date: Tue Apr 27 2021 - 02:36:15 EST


Hi,

On Tue, Apr 27, 2021 at 11:30:31AM +0800, Wan Jiabing wrote:
> struct scmi_protocol_handle is declared at 34th line.
> The declaration here is duplicate. Remove it.
>

You're right.

Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>

Thanks,
Cristian

> Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx>
> ---
> drivers/firmware/arm_scmi/notify.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/notify.h b/drivers/firmware/arm_scmi/notify.h
> index ce0324be6c71..4e9b627edfef 100644
> --- a/drivers/firmware/arm_scmi/notify.h
> +++ b/drivers/firmware/arm_scmi/notify.h
> @@ -79,8 +79,6 @@ struct scmi_protocol_events {
>
> int scmi_notification_init(struct scmi_handle *handle);
> void scmi_notification_exit(struct scmi_handle *handle);
> -
> -struct scmi_protocol_handle;
> int scmi_register_protocol_events(const struct scmi_handle *handle, u8 proto_id,
> const struct scmi_protocol_handle *ph,
> const struct scmi_protocol_events *ee);
> --
> 2.25.1
>