Re: [PATCH v2 3/3] can-isotp: Add error message if txqueuelen is too small

[Marc Kleine-Budde]

On 27.04.2021 05:21:49, Patrick Menschel wrote:
> This patch adds an additional error message in
> case that txqueuelen is set too small and
> advices the user to increase txqueuelen.
> 
> This is likely to happen even with small transfers if
> txqueuelen is at default value 10 frames.
> 
> Signed-off-by: Patrick Menschel <menschel.p@xxxxxxxxx>
> ---
>  net/can/isotp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/net/can/isotp.c b/net/can/isotp.c
> index 2075d8d9e..d08f95bfd 100644
> --- a/net/can/isotp.c
> +++ b/net/can/isotp.c
> @@ -797,10 +797,12 @@ static enum hrtimer_restart isotp_tx_timer_handler(struct hrtimer *hrtimer)
>  		can_skb_set_owner(skb, sk);
>  
>  		can_send_ret = can_send(skb, 1);
> -		if (can_send_ret)
> +		if (can_send_ret) {
>  			pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
>  				       __func__, ERR_PTR(can_send_ret));
> -
> +			if (can_send_ret == -ENOBUFS)
> +				pr_notice_once("can-isotp: tx queue is full, increasing txqueuelen may prevent this error");

I've added the missing "\n" at the end while applying the patch to
linux-can-next/testing.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature