Re: [PATCH v2 50/50] staging: rtl8723bs: macro DRIVER_PREFIX expands to lowercase driver name

From: Greg KH
Date: Tue Apr 27 2021 - 07:04:21 EST


On Sat, Apr 24, 2021 at 11:02:33AM +0200, Fabio Aiuto wrote:
> macro DRIVER_PREFIX expands to lowercase driver name.
>
> Signed-off-by: Fabio Aiuto <fabioaiuto83@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/include/rtw_debug.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h
> index 189f02a8300a..3a5b083e95a1 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_debug.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_debug.h
> @@ -7,7 +7,7 @@
> #ifndef __RTW_DEBUG_H__
> #define __RTW_DEBUG_H__
>
> -#define DRIVER_PREFIX "RTL8723BS: "
> +#define DRIVER_PREFIX "rtl8723bs: "

KBUILD_MODNAME should be used here, in the future.

But really, this shouldn't be needed at all, it's kind of pointless (if
it is being used, then odds are the places it is being used is wrong...)

thanks,

greg k-h