Re: [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h
From: Greg KH
Date: Tue Apr 27 2021 - 07:07:44 EST
On Sat, Apr 24, 2021 at 11:01:43AM +0200, Fabio Aiuto wrote:
> This patchset removes all remaining debug macros in rtw_debug.h
>
> DBG_871X_SEL macro is replaced with netdev_dbg() for it does
> a raw printk call which is not best recommended for a driver.
>
> @@
> expression sel;
> expression list args;
> identifier padapter;
> identifier func;
> @@
>
> func(..., struct adapter *padapter, ...) {
> <...
> - DBG_871X_SEL(sel, args);
> + netdev_dbg(padapter->pnetdev, args);
> ...>
>
> unused _DBG_871X_LEVEL macro declaration is removed.
>
> Beautified register dump in core/rtw_debug.c
>
> Some code cleaning is done and all other private component tracing
> macros are removed.
Nice work, thanks for doing all of this! Now queued up for 5.14-rc1.
greg k-h