Re: [PATCH v2] coccinelle: api: semantic patch to use pm_runtime_resume_and_get
From: Rafael J. Wysocki
Date: Tue Apr 27 2021 - 09:22:55 EST
On Tue, Apr 27, 2021 at 3:18 PM Johan Hovold <johan@xxxxxxxxxx> wrote:
> On Mon, Apr 26, 2021 at 08:54:04PM +0200, Julia Lawall wrote:
> > pm_runtime_get_sync keeps a reference count on failure, which can lead
> > to leaks. pm_runtime_resume_and_get drops the reference count in the
> > failure case. This rule very conservatively follows the definition of
> > pm_runtime_resume_and_get to address the cases where the reference
> > count is unlikely to be needed in the failure case.
> > pm_runtime_resume_and_get was introduced in
> > commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to
> > deal with usage counter")
> > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxxx>
> As I've said elsewhere, not sure trying to do a mass conversion of this
> is a good idea.
No, it isn't.
> People may not be used to the interface, but it is
> consistent and has its use. The recent flurry of conversions show that
> those also risk introducing new bugs in code that is currently tested
> and correct.
> By giving the script kiddies another toy like this, the influx of broken
> patches is just bound to increase.
> Would also be good to CC the PM maintainer on this issue.
There are many call sites in the kernel where replacing
pm_runtime_get_sync() with pm_runtime_resume_and_get() mechanically
would introduce an error, so please don't do that.
Every such replacement should be reviewed by the people familiar with
the code in question.