Re: [PATCH 061/190] Revert "xen/grant-table: remove multiple BUG_ON on gnttab_interface"

[Greg Kroah-Hartman]

On Wed, Apr 21, 2021 at 03:19:14PM +0200, Juergen Gross wrote:
> On 21.04.21 14:58, Greg Kroah-Hartman wrote:
> > This reverts commit d6bd6cf9feb81737f9f64d2c1acf98fdaacebad1.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> > 
> > Cc: Aditya Pakki <pakki001@xxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> The reverted patch didn't introduce any issue. I have verified that the
> BUG_ON()s are really impossible to trigger, and even if they would have
> been triggering, they'd be now replaced by NULL dereferences.
> 
> So I believe you can just drop this revert.

Thanks for the review, now dropped.

greg k-h