Re: [PATCH 158/190] Revert "ALSA: sb: fix a missing check of snd_ctl_add"

[Greg Kroah-Hartman]

On Wed, Apr 21, 2021 at 06:26:24PM +0200, Takashi Iwai wrote:
> On Wed, 21 Apr 2021 15:00:33 +0200,
> Greg Kroah-Hartman wrote:
> > 
> > This reverts commit beae77170c60aa786f3e4599c18ead2854d8694d.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> > 
> > Cc: Aditya Pakki <pakki001@xxxxxxx>
> > Cc: Takashi Iwai <tiwai@xxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> The original code change is fine, it's just adding an error return.
> OTOH, it would be safe even if we ignore the error, too (the mixer
> element is optional), and the driver is quite legacy.
> That said, feel free to revert it.

Thanks for the review, I'll keep it.

greg k-h