Re: broonie-sound/for-next bisection: baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2

From: Michael Walle
Date: Tue Apr 27 2021 - 10:16:16 EST


Am 2021-04-27 15:57, schrieb Mark Brown:
On Tue, Apr 27, 2021 at 03:43:42PM +0200, Michael Walle wrote:
Am 2021-04-27 14:51, schrieb Guillaume Tucker:
> On 27/04/2021 11:19, Mark Brown wrote:
> > On Tue, Apr 27, 2021 at 07:28:34AM +0900, Kuninori Morimoto wrote:

> > > > > If so, all sai1 - sai6 are using "fsl,vf610-sai",
> > > > > all saiX doesn't have .name. I think it should have different name.
> > > > > In your case, at least, sai5 / sai6 needs to have

Where does that (null) come from? I've briefly tried the following
patch and I'd assume I get a duplicate for "abc-wm8904-hifi", but I still
get the old (null)-wm8904-hifi.

diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 407a45e48eee..36280008b5c6 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -1081,6 +1081,7 @@ static int fsl_sai_probe(struct platform_device *pdev)
sai->cpu_dai_drv.symmetric_rate = 1;
sai->cpu_dai_drv.symmetric_channels = 1;
sai->cpu_dai_drv.symmetric_sample_bits = 1;
+ sai->cpu_dai_drv.name = "abc";

if (of_find_property(np, "fsl,sai-synchronous-rx", NULL) &&
of_find_property(np, "fsl,sai-asynchronous", NULL)) {


There was a question from Morimoto-san (quoted above) about the hardware
configuration so he could confirm what patches to write.

We are using two instances of the fsl,vf610-sai, yes. Was that the
question?

-michael