Re: [PATCH] uio: uio_pci_generic: add memory resource mappings

[Greg KH]

On Tue, Apr 27, 2021 at 11:06:46AM -0400, Firas Ashkar wrote:
> import memory resources from underlying pci device, thus allowing
> userspace applications to memory map those resources.
> 
> Signed-off-by: Firas Ashkar <firas.ashkar@xxxxxxxxxxxxxxxxxxxx>
> ---
> :100644 100644 c7d681fef198 efc43869131d M	drivers/uio/uio_pci_generic.c
>  drivers/uio/uio_pci_generic.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
> index c7d681fef198..efc43869131d 100644
> --- a/drivers/uio/uio_pci_generic.c
> +++ b/drivers/uio/uio_pci_generic.c
> @@ -72,7 +72,9 @@ static int probe(struct pci_dev *pdev,
>  			   const struct pci_device_id *id)
>  {
>  	struct uio_pci_generic_dev *gdev;
> +	struct uio_mem *uiomem;
>  	int err;
> +	int i;
>  
>  	err = pcim_enable_device(pdev);
>  	if (err) {
> @@ -101,6 +103,36 @@ static int probe(struct pci_dev *pdev,
>  			 "no support for interrupts?\n");
>  	}
>  
> +	uiomem = &gdev->info.mem[0];
> +	for (i = 0; i < MAX_UIO_MAPS; ++i) {
> +		struct resource *r = &pdev->resource[i];
> +
> +		if (r->flags != (IORESOURCE_SIZEALIGN | IORESOURCE_MEM))
> +			continue;
> +
> +		if (uiomem >= &gdev->info.mem[MAX_UIO_MAPS]) {
> +			dev_warn(
> +				&pdev->dev,
> +				"device has more than " __stringify(
> +					MAX_UIO_MAPS) " I/O memory resources.\n");
> +			break;
> +		}
> +
> +		uiomem->memtype = UIO_MEM_PHYS;
> +		uiomem->addr = r->start & PAGE_MASK;
> +		uiomem->offs = r->start & ~PAGE_MASK;
> +		uiomem->size =
> +			(uiomem->offs + resource_size(r) + PAGE_SIZE - 1) &
> +			PAGE_MASK;
> +		uiomem->name = r->name;
> +		++uiomem;
> +	}
> +
> +	while (uiomem < &gdev->info.mem[MAX_UIO_MAPS]) {
> +		uiomem->size = 0;
> +		++uiomem;
> +	}
> +
>  	return devm_uio_register_device(&pdev->dev, &gdev->info);
>  }
>  
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot