Re: [PATCH v1] coresight: add node to reset all coresight devices

[taozha]

On 2021-04-23 18:02, Greg Kroah-Hartman wrote:
> On Fri, Apr 23, 2021 at 04:29:38PM +0800, Tao Zhang wrote:
> > Add new reset_source_sink node to be able to disable all active
> > coresight devices.
> > In this way, we no longer need to manually disable all active
> > coresight devices one by one. After enabling multiple coresight
> > paths, users can reset their status more conveniently by this
> > node.
> >
> > This patch base on coresight-next repo
> > http://git.linaro.org/kernel/coresight.git/log/?h=next
> >
> > And this patch depends on the following patch
> > https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg2551216.html
> >
> > Signed-off-by: Tingwei Zhang <tingwei@xxxxxxxxxxxxxx>
> > Signed-off-by: Mao Jinlong <jinlmao@xxxxxxxxxxxxxx>
> > Signed-off-by: Tao Zhang <taozha@xxxxxxxxxxxxxx>
> > ---
> >  drivers/hwtracing/coresight/coresight-core.c | 72 
> > ++++++++++++++++++++++++----
> >  1 file changed, 64 insertions(+), 8 deletions(-)
>
> You added new sysfs files with no new Documentation/ABI entries, so we
> have no idea how to review this code to determine if it does what you
> want it to do :(
>
> thanks,
>
> greg k-h
I will update this part according to your suggestion in patch v2.

Best,
Tao