Re: [PATCH 2/2] m68k: introduce a virtual m68k machine

[Laurent Vivier]

Le 28/04/2021 à 14:07, Geert Uytterhoeven a écrit :
> Hi Laurent,
> 
> On Tue, Apr 27, 2021 at 7:20 PM Laurent Vivier <laurent@xxxxxxxxx> wrote:
>> Le 23/03/2021 à 23:14, Laurent Vivier a écrit :
>>> This machine allows to have up to 3.2 GiB and 128 Virtio devices.
>>>
>>> It is based on android goldfish devices.
>>>
>>> Signed-off-by: Laurent Vivier <laurent@xxxxxxxxx>
> 
>> As 5.12 has been released, is this possible to consider having this new machine in the next release?
>>
>> All changes are contained under arch/m68k and protected by the CONFIG_VIRT flag. This should not
>> have any impact on the other m68k machines. In any case, I'll be able to maintain the machine and
>> fix any problem.
> 
> Thanks for the reminder!
> 
> Please accept my apologies: I had completely forgotten about your patch.
> By the time it reappeared on my radar (due to Alexandre's reply), it was
> already too late for v5.13.

No problem.

> I have tested and reviewed your patch, great work!
> I'm confident this can make v5.14, with the small nits fixed.

Thank you for your review.

I will answer to some of your comments and update accordingly my patch.

Thanks,
Laurent