Re: [PATCH 2/4] lib/vsprintf.c: Make %p{D,d} mean as much components as possible

From: Andy Shevchenko
Date: Wed Apr 28 2021 - 11:10:39 EST


On Wed, Apr 28, 2021 at 5:56 PM Jia He <justin.he@xxxxxxx> wrote:
>
> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

Hmm... Okay.

> We have '%pD'(no digit following) for printing a filename. It may not be
> perfect (by default it only prints one component.
>
> %pD4 should be more than good enough, but we should make plain "%pD" mean
> "as much of the path that is reasonable" rather than "as few components as
> possible" (ie 1).

Sorry, but from above I didn't get why.

The commit message tells only about %pD, but patch changes behaviour
of the ~100 or so users of "%pd" without any explanation.

Besides that the patch is prepended only by one change (which is also
not related to %pD), while we have ~30 users which behaviour got
changed.


--
With Best Regards,
Andy Shevchenko