RE: [PATCH] tools/iio: iio_event_monitor: Fix ioctl error check

[Sa, Nuno]

> From: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> Sent: Wednesday, April 28, 2021 5:08 PM
> To: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen
> <lars@xxxxxxxxxx>; Peter Meerwald-Stadler
> <pmeerw@xxxxxxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Paul
> Cercueil <paul@xxxxxxxxxxxxxxx>
> Subject: [PATCH] tools/iio: iio_event_monitor: Fix ioctl error check
> 
> 
> The ioctrl() call will return errno=EINVAL if the device does not
> support the events interface, and not ENODEV.
> 
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>

Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>

> ---
>  tools/iio/iio_event_monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/iio/iio_event_monitor.c
> b/tools/iio/iio_event_monitor.c
> index bb03859db89d..cdd9a84f18fa 100644
> --- a/tools/iio/iio_event_monitor.c
> +++ b/tools/iio/iio_event_monitor.c
> @@ -323,7 +323,7 @@ int main(int argc, char **argv)
>  	ret = ioctl(fd, IIO_GET_EVENT_FD_IOCTL, &event_fd);
>  	if (ret == -1 || event_fd == -1) {
>  		ret = -errno;
> -		if (ret == -ENODEV)
> +		if (ret == -EINVAL)
>  			fprintf(stderr,
>  				"This device does not support
> events\n");
>  		else
> --
> 2.30.2