Re: [PATCH v6 1/3] dt-bindings:iio:adc: add generic settling-time-us and oversampling-ratio channel properties

From: Jonathan Cameron
Date: Wed Apr 28 2021 - 13:01:11 EST


On Wed, 28 Apr 2021 09:32:06 +0200
Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:

> Settling time and over sampling is a typical challenge for different IIO ADC
> devices. So, introduce channel specific settling-time-us and oversampling-ratio
> properties to cover this use case.
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
This and patch 2 both look good to me. Given Rob gave a minor comment on the
previous version I don't feel I need him to look at this again.

Will pick up in a few days if no other reviews come in to require a v7.

Thanks,

Jonathan

> ---
> Documentation/devicetree/bindings/iio/adc/adc.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> index 912a7635edc4..db348fcbb52c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> @@ -39,4 +39,16 @@ properties:
> The first value specifies the positive input pin, the second
> specifies the negative input pin.
>
> + settling-time-us:
> + description:
> + Time between enabling the channel and first stable readings.
> +
> + oversampling-ratio:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Oversampling is used as replacement of or addition to the low-pass filter.
> + In some cases, the desired filtering characteristics are a function the
> + device design and can interact with other characteristics such as
> + settling time.
> +
> additionalProperties: true