Re: [PATCH 1/2] dt-bindings: dma: add schema for altr,msgdma
From: Rob Herring
Date: Wed Apr 28 2021 - 18:15:28 EST
On Wed, 28 Apr 2021 14:44:12 +0200, Olivier Dautricourt wrote:
> - add schema for Altera mSGDMA bindings in devicetree.
> - add myself as 'Odd fixes' maintainer for this driver
>
> Signed-off-by: Olivier Dautricourt <olivier.dautricourt@xxxxxxxxxx>
> ---
> .../devicetree/bindings/dma/altr,msgdma.yaml | 62 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/altr,msgdma.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/dma/altr,msgdma.example.dts:21.54-27.11: Warning (unit_address_format): /example-0/dma-controller@0xff200b00: unit name should not have leading "0x"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/altr,msgdma.example.dt.yaml: example-0: 'dma-controller@0xff200b00' does not match any of the regexes: '.*-names$', '.*-supply$', '^#.*-cells$', '^#[a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+(,[0-9a-fA-F]+)*$', '^__.*__$', 'pinctrl-[0-9]+'
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/dt-core.yaml
See https://patchwork.ozlabs.org/patch/1471123
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.