Re: [RFT, PATCH v1 0/5] gpio: xilinx: convert to use bitmap API
From: Andy Shevchenko
Date: Thu Apr 29 2021 - 10:31:06 EST
On Thu, Apr 29, 2021 at 5:00 PM Srinivas Neeli <sneeli@xxxxxxxxxx> wrote:
>
> Hi Bartosz,
>
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Sent: Saturday, April 24, 2021 4:45 PM
> > To: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > Cc: linux-gpio <linux-gpio@xxxxxxxxxxxxxxx>; arm-soc <linux-arm-
> > kernel@xxxxxxxxxxxxxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx>;
> > Shubhrajyoti Datta <shubhraj@xxxxxxxxxx>; Srinivas Neeli
> > <sneeli@xxxxxxxxxx>; Michal Simek <michals@xxxxxxxxxx>; Linus Walleij
> > <linus.walleij@xxxxxxxxxx>; Yury Norov <yury.norov@xxxxxxxxx>; Rasmus
> > Villemoes <linux@xxxxxxxxxxxxxxxxxx>; Syed Nayyar Waris
> > <syednwaris@xxxxxxxxx>; William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
> > Subject: Re: [RFT, PATCH v1 0/5] gpio: xilinx: convert to use bitmap API
> >
> > On Fri, Apr 23, 2021 at 10:41:26PM +0200, Bartosz Golaszewski wrote:
> > > On Thu, Apr 8, 2021 at 4:55 PM Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > >
> > > > The change in the series has been inspired by [1], which, I think,
> > > > can be improved. Here I present the view how it can be done.
> > > >
> > > > The series marked as RFT since I have no hardware and I perform
> > > > compile test only.
> > > >
> > > > The patches 1 and 2 can be (independently) applied for v5.13, but
> > > > I'm not in hurry with the series, due to above (lack of real
> > > > testing). So I'm flexible in a way how it can be proceed.
> >
> > > > bitmap: Make bitmap_remap() and bitmap_bitremap() available to
> > users
> > > > gpio: xilinx: Correct kernel doc for xgpio_probe()
> >
> > Bart, thanks for the warm words, just pointing out that patches 1 and 2 has
> > been reviewed and may be applied for v5.13 cycle. Up to you.
> >
> > > I usually trust Andy with his work but is there any chance we can get
> > > a Tested-by before the merge window?
>
> Patches tested. Functionality working fine.
>
> Tested-by: Neeli Srinivas <sneeli@xxxxxxxxxx>
Thank you very much! I'll send a v2 with your tags after v5.13-rc1 is out.
--
With Best Regards,
Andy Shevchenko