Re: [PATCH v5 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver

[Bjorn Helgaas]

On Thu, Apr 29, 2021 at 03:59:54PM +0100, Lorenzo Pieralisi wrote:
> On Wed, Apr 28, 2021 at 02:47:13PM -0500, Bjorn Helgaas wrote:
> > On Tue, Apr 06, 2021 at 05:26:33PM +0800, Greentime Hu wrote:
> > > From: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > > 
> > > Add driver for the SiFive FU740 PCIe host controller.
> > > This controller is based on the DesignWare PCIe core.
> > > 
> > > Signed-off-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > > Co-developed-by: Henry Styles <hes@xxxxxxxxxx>
> > > Signed-off-by: Henry Styles <hes@xxxxxxxxxx>
> > > Co-developed-by: Erik Danie <erik.danie@xxxxxxxxxx>
> > > Signed-off-by: Erik Danie <erik.danie@xxxxxxxxxx>
> > > Co-developed-by: Greentime Hu <greentime.hu@xxxxxxxxxx>
> > > Signed-off-by: Greentime Hu <greentime.hu@xxxxxxxxxx>
> > 
> > Tripped over these errors while build testing with the .config below.
> 
> Sorry about that - the kbot did not managed to test it. Is it a
> randconfig ? I think we should ask the kbuild bot guys to add it,
> I think it can be done on a per-repo basis.

I don't know enough about the bot.  The lkp@xxxxxxxxx reports I get
include allyesconfig for x86_64; not sure why that wouldn't catch
this.

> Waiting for a fix asap - I can move/rebase some commits if the fix
> takes time.

If it's feasible you could just move the FU740 stuff to a different
branch so we can be sure to include the other dwc stuff.  Same for
brcmstb.

Oh, and Colin just posted a NULL pointer check that could be squashed
into the new mediatek-gen3 driver.

Bjorn