Re: [PATCH] ssb: Remove redundant assignment to err

[Michael Büsch]

On Thu, 29 Apr 2021 18:47:10 +0800
Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote:

> Variable 'err' is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
> 
> Clean up the following clang-analyzer warning:
> 
> drivers/ssb/main.c:1306:3: warning: Value stored to 'err' is never read
> [clang-analyzer-deadcode.DeadStores]
> drivers/ssb/main.c:1312:3: warning: Value stored to 'err' is never read
> [clang-analyzer-deadcode.DeadStores]
> 
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/ssb/main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index 0a26984..ab23554 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1303,13 +1303,11 @@ static int __init ssb_modinit(void)
>  	if (err) {
>  		pr_err("Broadcom 43xx PCI-SSB-bridge initialization failed\n");
>  		/* don't fail SSB init because of this */
> -		err = 0;
>  	}
>  	err = ssb_host_pcmcia_init();
>  	if (err) {
>  		pr_err("PCMCIA host initialization failed\n");
>  		/* don't fail SSB init because of this */
> -		err = 0;
>  	}
>  	err = ssb_gige_init();
>  	if (err) {


The assignment is there just as a visual guide to tell the reader that
we ignore the error.
However, there's also a comment that says the same thing. Therefore:

Acked-by: Michael Büsch <m@xxxxxxx>

-- 
Michael

Attachment: pgp78PP3CaVJP.pgp
Description: OpenPGP digital signature