Re: [PATCH] clk: meson: axg-audio: do not print error on defer

[Martin Blumenstingl]

Hi Jerome,

On Thu, Apr 29, 2021 at 11:06 AM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
[...]
> diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
> index 7c8d02164443..5e501eff0840 100644
> --- a/drivers/clk/meson/axg-audio.c
> +++ b/drivers/clk/meson/axg-audio.c
> @@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)
>
>         ret = device_reset(dev);
>         if (ret) {
> -               dev_err(dev, "failed to reset device\n");
> +               if (ret != -EPROBE_DEFER)
> +                       dev_err(dev, "failed to reset device\n");
many drivers are switching to dev_err_probe nowadays
According to it's documentation:
  In case of -EPROBE_DEFER it sets also defer probe reason, which can be
  checked later by reading devices_deferred debugfs attribute.

so I think it makes sense to use dev_err_probe here as well


Best regards,
Martin