Re: [PATCH net-next 3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding

From: Florian Fainelli
Date: Thu Apr 29 2021 - 19:32:21 EST




On 4/28/2021 11:21 PM, DENG Qingfang wrote:
> Add device tree binding to support MT7530 interrupt controller.
>
> Signed-off-by: DENG Qingfang <dqfext@xxxxxxxxx>
> ---
> RFC v4 -> PATCH v1:
> - No changes.
>
> Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/mt7530.txt b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
> index de04626a8e9d..892b1570c496 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mt7530.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
> @@ -81,6 +81,12 @@ Optional properties:
> - gpio-controller: Boolean; if defined, MT7530's LED controller will run on
> GPIO mode.
> - #gpio-cells: Must be 2 if gpio-controller is defined.
> +- interrupt-controller: Boolean; Enables the internal interrupt controller.
> +
> +If interrupt-controller is defined, the following property is required.

s/is/are/

It would be good to follow up with a converstion of this binding file to
YAML eventually.

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian