Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

[Linus Walleij]

On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:

> In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to
> avoid excessive unprepare / prepare") we started using pm_runtime, but
> my patch neglected to add the proper pm_runtime_disable(). Doh! Add
> them now.
>
> Fixes: 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare")
> Reported-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

This patch as such:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Notice however: you turn on pm runtime pm_runtime_enable()
in panel_simple_probe() but are you ever turning it off in
panel_simple_remove()?

I think pm_runtime_disable(); need to be added there?

Yours,
Linus Walleij