Re: [PATCH 1/4] x86/xen/entry: Rename xenpv_exc_nmi to noist_exc_nmi

[Paolo Bonzini]

On 28/04/21 23:27, Steven Rostedt wrote:
> On Tue, 27 Apr 2021 07:09:46 +0800
> Lai Jiangshan <jiangshanlai@xxxxxxxxx> wrote:
>
> > From: Lai Jiangshan <laijs@xxxxxxxxxxxxxxxxx>
> >
> > There is no any functionality change intended.  Just rename it and
> > move it to arch/x86/kernel/nmi.c so that we can resue it later in
> > next patch for early NMI and kvm.
>
> Nit, but in change logs, please avoid stating "next patch" as searching git
> history (via git blame or whatever) there is no such thing as "next patch".

Interesting, I use next patch(es) relatively often, though you're right 
that something like "in preparation for" works just as well.  Yes, it's 
the previous in "git log", but you get what it's meant in practice. :)

Paolo

> Just state: "so that we can reuse it for early NMI and KVM."
>
> I also just noticed the typo in "resue". Or maybe both NMI and KVM should
> be sued again ;-)
>
> -- Steve