Re: [PATCH] pinctrl: amd: Implement irq_set_wake

From: Andy Shevchenko
Date: Fri Apr 30 2021 - 05:22:28 EST


On Fri, Apr 30, 2021 at 1:34 AM Raul E Rangel <rrangel@xxxxxxxxxxxx> wrote:
>
> This allows the OS to control which devices produce wake events.
>
> $ grep enabled /sys/kernel/irq/*/wakeup
> /sys/kernel/irq/24/wakeup:enabled

Is it a bug fix of [1]?

If so, add a BugLink: tag here.

> Signed-off-by: Raul E Rangel <rrangel@xxxxxxxxxxxx>

[1]:

...

irq_hw_number_t hw = irqd_to_hwirq(d);

> + pin_reg = readl(gpio_dev->base + (d->hwirq)*4);

> + writel(pin_reg, gpio_dev->base + (d->hwirq)*4);

Too many parentheses and missed spaces


--
With Best Regards,
Andy Shevchenko