[PATCH Part1 RFC v2 19/20] x86/sev: Register SNP guest request platform device

From: Brijesh Singh
Date: Fri Apr 30 2021 - 08:18:46 EST


Version 2 of GHCB specification provides NAEs that can be used by the SNP
guest to communicate with the PSP without risk from a malicious hypervisor
who wishes to read, alter, drop or replay the messages sent.

The hypervisor uses the SNP_GUEST_REQUEST command interface provided by
the SEV-SNP firmware to forward the guest messages to the PSP.

In order to communicate with the PSP, the guest need to locate the secrets
page inserted by the hypervisor during the SEV-SNP guest launch. The
secrets page contains the communication keys used to send and receive the
encrypted messages between the guest and the PSP.

The secrets page is located either through the setup_data cc_blob_address
or EFI configuration table.

Create a platform device that the SNP guest driver will bind to get the
platform resources. The SNP guest driver will provide interface to get
the attestation report, key derivation etc.

See SEV-SNP and GHCB spec for more details.

Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>
---
arch/x86/kernel/sev.c | 124 ++++++++++++++++++++++++++++++++++++
arch/x86/platform/efi/efi.c | 2 +
include/linux/efi.h | 1 +
include/linux/snp-guest.h | 124 ++++++++++++++++++++++++++++++++++++
4 files changed, 251 insertions(+)
create mode 100644 include/linux/snp-guest.h

diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
index f28fd8605e63..6fd1f82f473a 100644
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -9,6 +9,7 @@

#define pr_fmt(fmt) "SEV-ES: " fmt

+#include <linux/platform_device.h>
#include <linux/sched/debug.h> /* For show_regs() */
#include <linux/percpu-defs.h>
#include <linux/mem_encrypt.h>
@@ -16,9 +17,12 @@
#include <linux/printk.h>
#include <linux/mm_types.h>
#include <linux/set_memory.h>
+#include <linux/snp-guest.h>
#include <linux/memblock.h>
#include <linux/kernel.h>
+#include <linux/efi.h>
#include <linux/mm.h>
+#include <linux/io.h>

#include <asm/cpu_entry_area.h>
#include <asm/stacktrace.h>
@@ -31,6 +35,7 @@
#include <asm/svm.h>
#include <asm/smp.h>
#include <asm/cpu.h>
+#include <asm/setup.h> /* For struct boot_params */

#define DR7_RESET_VALUE 0x400

@@ -101,6 +106,21 @@ struct ghcb_state {
struct ghcb *ghcb;
};

+/* Confidential computing blob information */
+#define CC_BLOB_SEV_HDR_MAGIC 0x414d4445
+struct cc_blob_sev_info {
+ u32 magic;
+ u16 version;
+ u64 secrets_phys;
+ u32 secrets_len;
+ u64 cpuid_phys;
+ u32 cpuid_len;
+};
+
+#ifdef CONFIG_EFI
+extern unsigned long cc_blob_phys;
+#endif
+
static DEFINE_PER_CPU(struct sev_es_runtime_data*, runtime_data);
DEFINE_STATIC_KEY_FALSE(sev_es_enable_key);

@@ -1685,3 +1705,107 @@ bool __init handle_vc_boot_ghcb(struct pt_regs *regs)
while (true)
halt();
}
+
+static struct resource guest_req_res[0];
+static struct platform_device guest_req_device = {
+ .name = "snp-guest",
+ .id = -1,
+ .resource = guest_req_res,
+ .num_resources = 1,
+};
+
+static int get_snp_secrets_resource(struct resource *res)
+{
+ struct setup_header *hdr = &boot_params.hdr;
+ struct cc_blob_sev_info *info;
+ unsigned long paddr;
+ int ret = -ENODEV;
+
+ /*
+ * The secret page contains the VM encryption key used for encrypting the
+ * messages between the guest and the PSP. The secrets page location is
+ * available either through the setup_data or EFI configuration table.
+ */
+ if (hdr->cc_blob_address) {
+ paddr = hdr->cc_blob_address;
+ } else if (efi_enabled(EFI_CONFIG_TABLES)) {
+#ifdef CONFIG_EFI
+ paddr = cc_blob_phys;
+#else
+ return -ENODEV;
+#endif
+ } else {
+ return -ENODEV;
+ }
+
+ info = memremap(paddr, sizeof(*info), MEMREMAP_WB);
+ if (!info)
+ return -ENOMEM;
+
+ if (info->magic == CC_BLOB_SEV_HDR_MAGIC && info->secrets_phys && info->secrets_len) {
+ res->start = info->secrets_phys;
+ res->end = info->secrets_phys + info->secrets_len;
+ res->flags = IORESOURCE_MEM;
+ ret = 0;
+ }
+
+ memunmap(info);
+ return ret;
+}
+
+static int __init add_snp_guest_request(void)
+{
+ if (!sev_snp_active())
+ return -ENODEV;
+
+ if (get_snp_secrets_resource(&guest_req_res[0]))
+ return -ENODEV;
+
+ platform_device_register(&guest_req_device);
+ dev_info(&guest_req_device.dev, "registered [secret 0x%016llx - 0x%016llx]\n",
+ guest_req_res[0].start, guest_req_res[0].end);
+
+ return 0;
+}
+device_initcall(add_snp_guest_request);
+
+unsigned long snp_issue_guest_request(int type, struct snp_guest_request_data *input)
+{
+ struct ghcb_state state;
+ struct ghcb *ghcb;
+ unsigned long id;
+ int ret;
+
+ if (type == SNP_GUEST_REQUEST)
+ id = SVM_VMGEXIT_SNP_GUEST_REQUEST;
+ else if (type == SNP_EXTENDED_GUEST_REQUEST)
+ id = SVM_VMGEXIT_SNP_EXT_GUEST_REQUEST;
+ else
+ return -EINVAL;
+
+ if (!sev_snp_active())
+ return -ENODEV;
+
+ ghcb = sev_es_get_ghcb(&state);
+ if (!ghcb)
+ return -ENODEV;
+
+ vc_ghcb_invalidate(ghcb);
+ ghcb_set_rax(ghcb, input->data_gpa);
+ ghcb_set_rbx(ghcb, input->data_npages);
+
+ ret = sev_es_ghcb_hv_call(ghcb, NULL, id, input->req_gpa, input->resp_gpa);
+
+ if (ret)
+ goto e_put;
+
+ if (ghcb->save.sw_exit_info_2) {
+ ret = ghcb->save.sw_exit_info_2;
+ goto e_put;
+ }
+
+e_put:
+ sev_es_put_ghcb(&state);
+ return ret;
+}
+EXPORT_SYMBOL_GPL(snp_issue_guest_request);
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 8a26e705cb06..2cca9ee6e1d4 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -57,6 +57,7 @@ static unsigned long efi_systab_phys __initdata;
static unsigned long prop_phys = EFI_INVALID_TABLE_ADDR;
static unsigned long uga_phys = EFI_INVALID_TABLE_ADDR;
static unsigned long efi_runtime, efi_nr_tables;
+unsigned long cc_blob_phys;

unsigned long efi_fw_vendor, efi_config_table;

@@ -66,6 +67,7 @@ static const efi_config_table_type_t arch_tables[] __initconst = {
#ifdef CONFIG_X86_UV
{UV_SYSTEM_TABLE_GUID, &uv_systab_phys, "UVsystab" },
#endif
+ {EFI_CC_BLOB_GUID, &cc_blob_phys, "CC blob" },
{},
};

diff --git a/include/linux/efi.h b/include/linux/efi.h
index 6b5d36babfcc..75aeb2a56888 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -344,6 +344,7 @@ void efi_native_runtime_setup(void);
#define EFI_CERT_SHA256_GUID EFI_GUID(0xc1c41626, 0x504c, 0x4092, 0xac, 0xa9, 0x41, 0xf9, 0x36, 0x93, 0x43, 0x28)
#define EFI_CERT_X509_GUID EFI_GUID(0xa5c059a1, 0x94e4, 0x4aa7, 0x87, 0xb5, 0xab, 0x15, 0x5c, 0x2b, 0xf0, 0x72)
#define EFI_CERT_X509_SHA256_GUID EFI_GUID(0x3bd2a492, 0x96c0, 0x4079, 0xb4, 0x20, 0xfc, 0xf9, 0x8e, 0xf1, 0x03, 0xed)
+#define EFI_CC_BLOB_GUID EFI_GUID(0x067b1f5f, 0xcf26, 0x44c5, 0x85, 0x54, 0x93, 0xd7, 0x77, 0x91, 0x2d, 0x42)

/*
* This GUID is used to pass to the kernel proper the struct screen_info
diff --git a/include/linux/snp-guest.h b/include/linux/snp-guest.h
new file mode 100644
index 000000000000..32f70605b52c
--- /dev/null
+++ b/include/linux/snp-guest.h
@@ -0,0 +1,124 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * AMD Secure Encrypted Virtualization (SEV) driver interface
+ *
+ * Copyright (C) 2021 Advanced Micro Devices, Inc.
+ *
+ * Author: Brijesh Singh <brijesh.singh@xxxxxxx>
+ *
+ * SEV API spec is available at https://developer.amd.com/sev
+ */
+
+#ifndef __LINUX_SNP_GUEST_H_
+#define __LINUX_SNP_GUEST_H_
+
+#include <linux/types.h>
+
+#define MAX_AUTHTAG_LEN 32
+#define VMPCK_KEY_LEN 32
+
+/*
+ * The secrets page contains 96-bytes of reserved field that can be used by
+ * the guest OS. The guest OS uses the area to save the message sequence
+ * number for each VMPL level.
+ */
+struct secrets_guest_priv {
+ u64 msg_seqno_0;
+ u64 msg_seqno_1;
+ u64 msg_seqno_2;
+ u64 msg_seqno_3;
+ u8 rsvd[64];
+} __packed;
+
+/* See the SNP spec secrets page layout section for the structure */
+struct snp_data_secrets_layout {
+ u32 version;
+ u32 imiEn:1;
+ u32 rsvd1:31;
+ u32 fms;
+ u32 rsvd2;
+ u8 gosvw[16];
+ u8 vmpck0[VMPCK_KEY_LEN];
+ u8 vmpck1[VMPCK_KEY_LEN];
+ u8 vmpck2[VMPCK_KEY_LEN];
+ u8 vmpck3[VMPCK_KEY_LEN];
+ struct secrets_guest_priv guest_priv;
+ u8 rsvd3[3840];
+} __packed;
+
+/* See SNP spec SNP_GUEST_REQUEST section for the structure */
+enum msg_type {
+ SNP_MSG_TYPE_INVALID = 0,
+ SNP_MSG_CPUID_REQ,
+ SNP_MSG_CPUID_RSP,
+ SNP_MSG_KEY_REQ,
+ SNP_MSG_KEY_RSP,
+ SNP_MSG_REPORT_REQ,
+ SNP_MSG_REPORT_RSP,
+ SNP_MSG_EXPORT_REQ,
+ SNP_MSG_EXPORT_RSP,
+ SNP_MSG_IMPORT_REQ,
+ SNP_MSG_IMPORT_RSP,
+ SNP_MSG_ABSORB_REQ,
+ SNP_MSG_ABSORB_RSP,
+ SNP_MSG_VMRK_REQ,
+ SNP_MSG_VMRK_RSP,
+
+ SNP_MSG_TYPE_MAX
+};
+
+enum aead_algo {
+ SNP_AEAD_INVALID,
+ SNP_AEAD_AES_256_GCM,
+};
+
+struct snp_guest_msg_hdr {
+ u8 authtag[MAX_AUTHTAG_LEN];
+ u64 msg_seqno;
+ u8 rsvd1[8];
+ u8 algo;
+ u8 hdr_version;
+ u16 hdr_sz;
+ u8 msg_type;
+ u8 msg_version;
+ u16 msg_sz;
+ u32 rsvd2;
+ u8 msg_vmpck;
+ u8 rsvd3[35];
+} __packed;
+
+struct snp_guest_msg {
+ struct snp_guest_msg_hdr hdr;
+ u8 payload[4000];
+} __packed;
+
+struct snp_msg_report_req {
+ u8 data[64];
+ u32 vmpl;
+ u8 rsvd[28];
+} __packed;
+
+enum vmgexit_type {
+ SNP_GUEST_REQUEST,
+ SNP_EXTENDED_GUEST_REQUEST,
+
+ GUEST_REQUEST_MAX
+};
+
+struct snp_guest_request_data {
+ unsigned long req_gpa;
+ unsigned long resp_gpa;
+ unsigned long data_gpa;
+ unsigned int data_npages;
+};
+
+#ifdef CONFIG_AMD_MEM_ENCRYPT
+unsigned long snp_issue_guest_request(int vmgexit_type, struct snp_guest_request_data *input);
+#else
+
+static inline unsigned long snp_issue_guest_request(int type, struct snp_guest_request_data *input)
+{
+ return -ENODEV;
+}
+#endif /* CONFIG_AMD_MEM_ENCRYPT */
+#endif /* __LINUX_SNP_GUEST_H__ */
--
2.17.1