Re: [PATCH 2/3] dt-bindings: hwmon: pmbus: Add Delta DPS920AB PSU driver bindings

[Guenter Roeck]

On Fri, Apr 30, 2021 at 03:27:34PM +0200, Robert Marko wrote:
> Add binding document for the Delta DPS920AB PSU driver.
> 

Is there a reason to not just add delta,dps920ab to the list of trivial
devices ?

Thanks,
Guenter

> Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> ---
>  .../bindings/hwmon/pmbus/delta,dps920ab.yaml  | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/delta,dps920ab.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/delta,dps920ab.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/delta,dps920ab.yaml
> new file mode 100644
> index 000000000000..e05363a8e455
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/delta,dps920ab.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/pmbus/delta,dps920ab.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Delta DPS920AB power supply
> +
> +maintainers:
> +  - Robert Marko <robert.marko@xxxxxxxxxx>
> +
> +description: |
> +  Delta DPS920AB is a 920W 54V DC single output power supply
> +  with active PFC capable of 16.88A on the 54V output.
> +  It has a built in PWM capable fan with tachometer.
> +  PMBus is used to expose information about the PSU.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - delta,dps920ab
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        psu@5a {
> +            compatible = "delta,dps920ab";
> +            reg = <0x5a>;
> +        };
> +    };
> -- 
> 2.31.1
>