Re: Re: [PATCH] musb: mediatek: rename driver

[Greg Kroah-Hartman]

Please do not top-post :)

On Fri, Apr 30, 2021 at 03:30:39PM +0200, Frank Wunderlich wrote:
> Hi Grek
> 
> the problem is that the name mediatek.ko does not point to musb-subsystem. I had discussed with Min Gao (author of this driver) some time ago about this as the name may conflict with other modules (don't remember which was that).
> We have searched issue using the driver on my board (not yet resolved).
> 
> if the module is loaded it shows (based on name) only "mediatek" and user does not know that is the mediatek musb driver, not very good in my eyes as mediatek is a vendor designing many different hardware and so drivers. Imho the module-name should at least give a clue to the subsystem to avoid confusion/conflicts
> 
> Now the discussion comes up again here for a new driver:
> https://patchwork.kernel.org/project/linux-mediatek/cover/20210429062130.29403-1-dqfext@xxxxxxxxx/#24148777
> 
> so i decided to rebase and post my patch created in past to clean this up.

All of this information needs to go into the changelog text, what you
wrote there does not explain all of the above.

> and yes this can result in user-space issues depending on the name...because of this i have not added stable-tag ;)

Why does stable matter?  If this could result in a userspace breakage,
that's not ok for any kernel change.

Why not just have any new driver not use this name, as it is, it's not
hurting anything.  Until you can guarantee that renaming this is not
going to break anything, I can not take it.

thanks,

greg k-h