Re: [PATCH] scsi: target: configfs: Remove redundant assignment to ret

[Bodo Stroesser]

On 30.04.21 17:40, michael.christie@xxxxxxxxxx wrote:
> On 4/30/21 9:29 AM, Bodo Stroesser wrote:
> > BTW: why is "initiator_sid" input handled as string?
> > core_scsi3_alloc_aptpl_registration later calls get_unaligned_be64 for
> > that string. I don't think this makes sense.
>
> It's broken.
>
> Remember the isid patches that you reviewed of mine trying to fix the
> isid code in target_core_transport.c? I can't remember all the details but
> I think it was that the aptpl code thinks the buffer is in the format that
> sess_get_initiator_sid uses and is trying to do something similar as
> target_core_transport.c.
>
> I can't find the version of the patches you had looked at. This was the first
> version of the patch:
>
> https://patchwork.kernel.org/project/target-devel/patch/1531696591-8558-3-git-send-email-mchristi@xxxxxxxxxx/

Ahh, yes. I remember. Thank you.