Re: [PATCH AUTOSEL 5.12 16/79] usb: dwc3: gadget: Remove invalid low-speed setting
From: Greg Kroah-Hartman
Date: Sun May 02 2021 - 11:00:42 EST
On Sun, May 02, 2021 at 10:02:13AM -0400, Sasha Levin wrote:
> From: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
>
> [ Upstream commit 0c59f678fcfc6dd53ba493915794636a230bc4cc ]
>
> None of the DWC_usb3x IPs (and all their versions) supports low-speed
> setting in device mode. In the early days, our "Early Adopter Edition"
> DWC_usb3 databook shows that the controller may be configured to operate
> in low-speed, but it was revised on release. Let's remove this invalid
> speed setting to avoid any confusion.
>
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/258b1c7fbb966454f4c4c2c1367508998498fc30.1615509438.git.Thinh.Nguyen@xxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
> drivers/usb/dwc3/core.c | 1 -
> drivers/usb/dwc3/core.h | 2 --
> drivers/usb/dwc3/gadget.c | 8 --------
> 3 files changed, 11 deletions(-)
This is a "cleanup only" and does not fix or solve anything, so it can
be dropped from all of the kernels it has been "autoselected" for.
thanks,
greg k-h