Re: [PATCH v3 16/43] staging: rtl8723bs: remove unused ASSERT macro

From: Fabio Aiuto
Date: Mon May 03 2021 - 03:43:15 EST


On Mon, May 03, 2021 at 10:31:32AM +0300, Dan Carpenter wrote:
> On Fri, Apr 30, 2021 at 04:56:38PM +0200, Fabio Aiuto wrote:
> > remove unused do nothing ASSERT macro definition.
> >
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@xxxxxxxxx>
> > ---
> > drivers/staging/rtl8723bs/hal/odm_debug.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h
> > index 8ae9948fb0c6..78b9b4548dcb 100644
> > --- a/drivers/staging/rtl8723bs/hal/odm_debug.h
> > +++ b/drivers/staging/rtl8723bs/hal/odm_debug.h
> > @@ -92,7 +92,6 @@
> > #define RT_DISP(dbgtype, dbgflag, printstr)
> >
> > #ifndef ASSERT
> > - #define ASSERT(expr)
> > #endif
>
> Presumably you're going to delete the #ifndef/endif in the next patch
> but it should have been done in one step here. (No need to resend. For
> future reference only).
>
> regards,
> dan carpenter
>

ok, thank you,

fabio