Re: [PATCH 08/16] dt-bindings: imx: gpcv2: add support for optional resets

[Frieder Schrempf]

On 29.04.21 09:30, Peng Fan (OSS) wrote:
> From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>
> For some domains the resets of the devices in the domain are not
> automatically triggered. Add an optional resets property to allow
> the GPC driver to trigger those resets explicitly.
>
> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

Rob has approved this if it includes a proper explanation on why the 
resets are not defined. See: 
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201105174434.1817539-9-l.stach@xxxxxxxxxxxxxx/#24147743.

Can you add an explanation to the bindings in the next version?

> ---
>   Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> index a96e6dbf1858..4330c73a2c30 100644
> --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
> @@ -66,6 +66,13 @@ properties:
>   
>             power-supply: true
>   
> +          resets:
> +            description: |
> +              A number of phandles to resets that need to be asserted during
> +              power-up sequencing of the domain.
> +            minItems: 1
> +            maxItems: 4
> +
>           required:
>             - '#power-domain-cells'
>             - reg