[PATCH v1 05/12] lib/string_helpers: Drop indentation level in string_escape_mem()

From: Andy Shevchenko
Date: Mon May 03 2021 - 16:49:30 EST


The only one conditional is left on the upper level, move the rest
to the same level and drop indentation level. No functional changes.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
lib/string_helpers.c | 47 ++++++++++++++++++++++----------------------
1 file changed, 23 insertions(+), 24 deletions(-)

diff --git a/lib/string_helpers.c b/lib/string_helpers.c
index 26e35018684f..8e58e2c6f83d 100644
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -532,37 +532,36 @@ int string_escape_mem(const char *src, size_t isz, char *dst, size_t osz,
* In these cases we just pass through a character to the
* output buffer.
*/
- if (is_dict && !strchr(only, c)) {
- /* do nothing */
- } else {
- if (isascii(c) && isprint(c) &&
- flags & ESCAPE_NAP && escape_passthrough(c, &p, end))
- continue;
+ if (is_dict && !strchr(only, c) && escape_passthrough(c, &p, end))
+ continue;

- if (isprint(c) &&
- flags & ESCAPE_NP && escape_passthrough(c, &p, end))
- continue;
+ if (isascii(c) && isprint(c) &&
+ flags & ESCAPE_NAP && escape_passthrough(c, &p, end))
+ continue;

- if (isascii(c) &&
- flags & ESCAPE_NA && escape_passthrough(c, &p, end))
- continue;
+ if (isprint(c) &&
+ flags & ESCAPE_NP && escape_passthrough(c, &p, end))
+ continue;

- if (flags & ESCAPE_SPACE && escape_space(c, &p, end))
- continue;
+ if (isascii(c) &&
+ flags & ESCAPE_NA && escape_passthrough(c, &p, end))
+ continue;

- if (flags & ESCAPE_SPECIAL && escape_special(c, &p, end))
- continue;
+ if (flags & ESCAPE_SPACE && escape_space(c, &p, end))
+ continue;

- if (flags & ESCAPE_NULL && escape_null(c, &p, end))
- continue;
+ if (flags & ESCAPE_SPECIAL && escape_special(c, &p, end))
+ continue;

- /* ESCAPE_OCTAL and ESCAPE_HEX always go last */
- if (flags & ESCAPE_OCTAL && escape_octal(c, &p, end))
- continue;
+ if (flags & ESCAPE_NULL && escape_null(c, &p, end))
+ continue;

- if (flags & ESCAPE_HEX && escape_hex(c, &p, end))
- continue;
- }
+ /* ESCAPE_OCTAL and ESCAPE_HEX always go last */
+ if (flags & ESCAPE_OCTAL && escape_octal(c, &p, end))
+ continue;
+
+ if (flags & ESCAPE_HEX && escape_hex(c, &p, end))
+ continue;

escape_passthrough(c, &p, end);
}
--
2.30.2