Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem()

From: Andy Shevchenko
Date: Mon May 03 2021 - 17:14:27 EST


On Tue, May 4, 2021 at 12:11 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, May 4, 2021 at 12:09 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, May 03, 2021 at 11:56:41PM +0300, Andy Shevchenko wrote:
> > > On Mon, May 3, 2021 at 11:54 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

...

> > > Any suggestions how to replace that API with a newer one?
> >
> > seq_escape_mem(), perhaps?
>
> I think I have a better idea. What about adding seq_escape_with_flags()
> and seq_escape() --> seq_escape_with_flags(..., ESCAPE_OCTAL, ...) ?
>
> Would it work for you?

Ah, it wouldn't work for the user, because it wants to pass the buffer size.
Okay, I'll take your suggestion, thanks!

--
With Best Regards,
Andy Shevchenko