Re: [RESEND PATCH] bus: mhi: core: Remove pre_init flag used for power purposes

From: Jeffrey Hugo
Date: Tue May 04 2021 - 13:34:03 EST


On 4/6/2021 11:07 PM, Manivannan Sadhasivam wrote:
On Thu, Apr 01, 2021 at 02:41:49PM -0700, Bhaumik Bhatt wrote:
Some controllers can choose to skip preparation for power up.
In that case, device context is initialized based on the pre_init
flag not being set during mhi_prepare_for_power_up(). There is no
reason MHI host driver should maintain and provide controllers
with two separate paths for preparing MHI.

Going forward, all controllers will be required to call the
mhi_prepare_for_power_up() API followed by their choice of sync
or async power up. This allows MHI host driver to get rid of the
pre_init flag and sets up a common way for all controllers to use
MHI. This also helps controllers fail early on during preparation
phase in some failure cases.

Signed-off-by: Bhaumik Bhatt <bbhatt@xxxxxxxxxxxxxx>

I hope Jeff is also okay with this patch for AIC100.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>


Sorry for the non-response. This has minimal impact. No concerns from me.