Re: [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI
From: Andy Shevchenko
Date: Tue May 04 2021 - 13:46:48 EST
On Tue, May 4, 2021 at 8:44 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, May 4, 2021 at 8:40 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> >
> > With CONFIG_ACPI=n and -Werror, 0-day reports:
> >
> > drivers/iio/chemical/bme680_i2c.c:46:36: error:
> > 'bme680_acpi_match' defined but not used
>
> > Given the other patch, question of course is if this ACPI ID
> > is real. A Google search suggests that this might not be the case.
> > Should we remove it as well ? STK8312 has the same problem.
>
> For this one definitely removal. Looking into the code it suggests a
> cargo cult taken that time by a few contributors to invent fake ACPI
> IDs while submitting new drivers.
> Feel free to add my tag or if you wish me I'll add it explicitly.
Had just looked at STK, the same guy as for AOS2315. So, also to remove.
--
With Best Regards,
Andy Shevchenko