Re: [PATCH 25/35] tty: remove tty_operations::chars_in_buffer for non-buffering

From: Max Filippov
Date: Wed May 05 2021 - 07:52:06 EST


On Wed, May 5, 2021 at 2:19 AM Jiri Slaby <jslaby@xxxxxxx> wrote:
>
> The only user of tty_ops::chars_in_buffer is tty_chars_in_buffer. And it
> considers tty_ops::chars_in_buffer optional. In case it's NULL, zero is
> returned. So remove all those chars_in_buffer from tty_ops which return
> zero. (Zero means such driver doesn't buffer.)
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> c: Richard Henderson <rth@xxxxxxxxxxx>
> Cc: Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>
> Cc: Matt Turner <mattst88@xxxxxxxxx>
> Cc: "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Helge Deller <deller@xxxxxx>
> Cc: Chris Zankel <chris@xxxxxxxxxx>
> Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
> Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>
> Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> ---
> arch/alpha/kernel/srmcons.c | 7 -------
> arch/parisc/kernel/pdc_cons.c | 6 ------
> arch/xtensa/platforms/iss/console.c | 7 -------
> drivers/s390/char/tty3270.c | 12 ------------
> drivers/tty/pty.c | 17 -----------------
> drivers/tty/vt/vt.c | 6 ------
> 6 files changed, 55 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx> # xtensa

--
Thanks.
-- Max