Re: [PATCH 22/35] tty: make tty_operations::write_room return uint
From: Alex Elder
Date: Wed May 05 2021 - 08:17:53 EST
On 5/5/21 4:19 AM, Jiri Slaby wrote:
Line disciplines expect a positive value or zero returned from
tty->ops->write_room (invoked by tty_write_room). So make this
assumption explicit by using unsigned int as a return value. Both of
tty->ops->write_room and tty_write_room.
Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
Cc: Richard Henderson <rth@xxxxxxxxxxx>
Cc: Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>
Cc: Matt Turner <mattst88@xxxxxxxxx>
Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Cc: "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
Cc: Helge Deller <deller@xxxxxx>
Cc: Jeff Dike <jdike@xxxxxxxxxxx>
Cc: Richard Weinberger <richard@xxxxxx>
Cc: Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>
Cc: Chris Zankel <chris@xxxxxxxxxx>
Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>
Cc: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
Cc: Karsten Keil <isdn@xxxxxxxxxxxxxx>
Cc: Scott Branden <scott.branden@xxxxxxxxxxxx>
Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>
Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
Cc: David Lin <dtwlin@xxxxxxxxx>
Cc: Johan Hovold <johan@xxxxxxxxxx>
Cc: Alex Elder <elder@xxxxxxxxxx>
Cc: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
Cc: Jiri Kosina <jikos@xxxxxxxxxx>
Cc: David Sterba <dsterba@xxxxxxxx>
Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Cc: Oliver Neukum <oneukum@xxxxxxxx>
Cc: Felipe Balbi <balbi@xxxxxxxxxx>
Cc: Mathias Nyman <mathias.nyman@xxxxxxxxx>
Cc: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Cc: Johan Hedberg <johan.hedberg@xxxxxxxxx>
Cc: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>
---
arch/alpha/kernel/srmcons.c | 2 +-
arch/m68k/emu/nfcon.c | 2 +-
arch/parisc/kernel/pdc_cons.c | 2 +-
arch/um/drivers/line.c | 6 +++---
arch/um/drivers/line.h | 2 +-
arch/xtensa/platforms/iss/console.c | 2 +-
drivers/char/pcmcia/synclink_cs.c | 2 +-
drivers/char/ttyprintk.c | 2 +-
drivers/ipack/devices/ipoctal.c | 2 +-
drivers/isdn/capi/capi.c | 6 +++---
drivers/misc/bcm-vk/bcm_vk_tty.c | 2 +-
drivers/mmc/core/sdio_uart.c | 2 +-
drivers/net/usb/hso.c | 4 ++--
drivers/s390/char/con3215.c | 2 +-
drivers/s390/char/sclp_tty.c | 4 ++--
drivers/s390/char/sclp_vt220.c | 4 ++--
drivers/s390/char/tty3270.c | 2 +-
drivers/staging/fwserial/fwserial.c | 6 +++---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
drivers/staging/greybus/uart.c | 2 +-
drivers/tty/amiserial.c | 2 +-
drivers/tty/ehv_bytechan.c | 4 ++--
drivers/tty/goldfish.c | 2 +-
drivers/tty/hvc/hvc_console.c | 2 +-
drivers/tty/hvc/hvcs.c | 2 +-
drivers/tty/hvc/hvsi.c | 4 ++--
drivers/tty/ipwireless/tty.c | 2 +-
drivers/tty/mips_ejtag_fdc.c | 4 ++--
drivers/tty/moxa.c | 8 ++++----
drivers/tty/mxser.c | 2 +-
drivers/tty/n_gsm.c | 2 +-
drivers/tty/nozomi.c | 4 ++--
drivers/tty/pty.c | 2 +-
drivers/tty/serial/kgdb_nmi.c | 2 +-
drivers/tty/serial/serial_core.c | 4 ++--
drivers/tty/synclink_gt.c | 6 +++---
drivers/tty/tty_ioctl.c | 2 +-
drivers/tty/ttynull.c | 2 +-
drivers/tty/vcc.c | 4 ++--
drivers/tty/vt/vt.c | 2 +-
drivers/usb/class/cdc-acm.c | 2 +-
drivers/usb/gadget/function/u_serial.c | 6 +++---
drivers/usb/host/xhci-dbgtty.c | 4 ++--
drivers/usb/serial/usb-serial.c | 2 +-
include/linux/tty.h | 2 +-
include/linux/tty_driver.h | 4 ++--
net/bluetooth/rfcomm/tty.c | 2 +-
47 files changed, 71 insertions(+), 71 deletions(-)
. . .
Looks good.
Acked-by: Alex Elder <elder@xxxxxxxxxx.
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index b1e63f7798b0..529eccb99b6c 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -440,7 +440,7 @@ static int gb_tty_write(struct tty_struct *tty, const unsigned char *buf,
return count;
}
-static int gb_tty_write_room(struct tty_struct *tty)
+static unsigned int gb_tty_write_room(struct tty_struct *tty)
{
struct gb_tty *gb_tty = tty->driver_data;
unsigned long flags;
. . .