Re: [PATCH v2 3/3] arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts

[Martin Blumenstingl]

Hi Neil,

On Wed, May 5, 2021 at 9:32 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>
> Banana Pi BPI-M5 is a credit card format SBC with the following features:
> - Amlogic S905X3 quad core Cortex-A55
> - Mali-G31 GPU
> - 4GB LPDDR4
> - 16GB eMMC flash
> - 4 USB 3.0
> - 1 GbE ethernet
> - HDMI output
> - 2x LEDS
> - SDCard
> - 2.5mm Jack with Stereo Audio + CVBS
> - Infrared Received
> - ADC Button
> - GPIO Button
> - 40 pins header + 3pins debug header
>
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
one nit-pick below, but still this gets my:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

[...]
> +       /*
> +        * WARNING: The USB Hub on the BPI-M54 needs a reset signal
s/BPI-M5/BPI-M54/
I am hoping that Kevin can fix this while applying


Best regards,
Martin