Re: [PATCH] cxl: Fix an error message

[Andrew Donnellan]

On 6/5/21 5:38 am, Christophe JAILLET wrote:
> 'rc' is known to be 0 here.
> Initialize 'rc' with the expected error code before using it.

I would prefer:

"In cxl_add_chardev(), if the call to device_create() fails, we print 
the error message before 'rc' is set correctly, and therefore always 
print 0. Move the error message after setting 'rc'."

> While at it, avoid the affectation of 'rc' in a 'if' to make things more
> obvious and linux style.

I strongly agree with this, some of the other cxl developers don't but 
they are wrong :)

> Fixes: f204e0b8ce ("cxl: Driver code for powernv PCIe based cards for userspace access")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Apart from my comment above:

Acked-by: Andrew Donnellan <ajd@xxxxxxxxxxxxx>

Thanks for catching this!

--
Andrew Donnellan              OzLabs, ADL Canberra
ajd@xxxxxxxxxxxxx             IBM Australia Limited