Re: [PATCH 3/3] Input: mtk-pmic-keys - add support for MT6358

From: kernel test robot
Date: Thu May 06 2021 - 14:43:02 EST


Hi Mattijs,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on input/next]
[also build test ERROR on v5.12 next-20210506]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Mattijs-Korpershoek/MT6358-PMIC-button-support/20210506-234207
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/504339f7cba56983b5e2530aaa498ae829a50587
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mattijs-Korpershoek/MT6358-PMIC-button-support/20210506-234207
git checkout 504339f7cba56983b5e2530aaa498ae829a50587
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=ia64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/input/keyboard/mtk-pmic-keys.c:80:22: error: 'MT6358_TOPSTATUS' undeclared here (not in a function); did you mean 'MT6397_OCSTATUS2'?
80 | MTK_PMIC_KEYS_REGS(MT6358_TOPSTATUS,
| ^~~~~~~~~~~~~~~~
drivers/input/keyboard/mtk-pmic-keys.c:47:14: note: in definition of macro 'MTK_PMIC_KEYS_REGS'
47 | .deb_reg = _deb_reg, \
| ^~~~~~~~
>> drivers/input/keyboard/mtk-pmic-keys.c:85:18: error: 'MT6358_TOP_RST_MISC' undeclared here (not in a function); did you mean 'MT6397_TOP_RST_MISC'?
85 | .pmic_rst_reg = MT6358_TOP_RST_MISC,
| ^~~~~~~~~~~~~~~~~~~
| MT6397_TOP_RST_MISC


vim +80 drivers/input/keyboard/mtk-pmic-keys.c

77
78 static const struct mtk_pmic_regs mt6358_regs = {
79 .keys_regs[MTK_PMIC_PWRKEY_INDEX] =
> 80 MTK_PMIC_KEYS_REGS(MT6358_TOPSTATUS,
81 0x2, MT6358_PSC_TOP_INT_CON0, 0x5),
82 .keys_regs[MTK_PMIC_HOMEKEY_INDEX] =
83 MTK_PMIC_KEYS_REGS(MT6358_TOPSTATUS,
84 0x8, MT6358_PSC_TOP_INT_CON0, 0xa),
> 85 .pmic_rst_reg = MT6358_TOP_RST_MISC,
86 };
87

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip