Re: [PATCH v5 00/20] Introduce threaded trace streaming for basic perf record operation

From: Namhyung Kim
Date: Fri May 07 2021 - 00:48:48 EST


On Thu, May 6, 2021 at 5:44 AM Bayduraev, Alexey V
<alexey.v.bayduraev@xxxxxxxxxxxxxxx> wrote:
>
> Hi,
>
> On 06.05.2021 9:20, Namhyung Kim wrote:
> > Hello,
> >
> > On Tue, May 4, 2021 at 12:05 AM Alexey Bayduraev
> > <alexey.v.bayduraev@xxxxxxxxxxxxxxx> wrote:
> >>
> <SNIP>>>
> >> Basic analysis of data directories is provided in perf report mode.
> >> Raw dump and aggregated reports are available for data directories,
> >> still with no memory consumption optimizations.
> >
> > Do you have an idea how to improve it?
> >
> > I have to say again that I don't like merely adding more threads to
> > record. Yeah, parallelizing the perf record is good, but we have to
> > think about the perf report (and others) too.
>
> There is your idea about separating tracking records and process them
> first, but these changes can be much larger than my patch and I think
> they looks like independent patch and could be introduced as extension
> of parallel data loading.
>
> I also thought and experimented with the intermediate flushing of
> the ordered queue. This is simple for per-cpu data files (sorted
> by time), but not clear for arbitrary CPU masks.
>
> I think my patch can be the first step to introduce parallel mode
> to the perf tool. It just extends perf-record (already used in our
> vtune tool) and allows to load parallel data in experimental mode.
> Next patches could optimize and extend parallel data loading.

Yeah I agree that we can change it incrementally and good to
know that you are thinking about the next step. :)

Thanks,
Namhyung