Re: [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name

[Maxime Ripard]

Hi,

On Thu, Apr 29, 2021 at 10:58:59PM -0500, Samuel Holland wrote:
> From: Arnaud Ferraris <arnaud.ferraris@xxxxxxxxxxxxx>
> 
> Add the "PinePhone" name to the sound card: this will make
> upstreaming an ALSA UCM config easier as we can use a unique name.
> 
> It also avoids an issue where the default card name is truncated.
> 
> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@xxxxxxxxxxxxx>
> [Samuel: Split out change, updated commit message]
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index 51cbfdc12936..02712f85f6bd 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -433,6 +433,7 @@ &reg_rtc_ldo {
>  
>  &sound {
>  	status = "okay";
> +	simple-audio-card,name = "PinePhone";
>  	simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>;
>  	simple-audio-card,widgets = "Microphone", "Headset Microphone",
>  				    "Microphone", "Internal Microphone",

Isn't that reported to the userspace? I'm not sure we can just change it
without breaking it.

Maxime

Attachment: signature.asc
Description: PGP signature