Re: [PATCH 09/11] mmc: core: Read the SD function extension registers for power management

From: Ulf Hansson
Date: Fri May 07 2021 - 07:37:15 EST


On Fri, 7 May 2021 at 09:48, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
>
> On 2021/5/7 15:27, Ulf Hansson wrote:
> > On Fri, 7 May 2021 at 04:06, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
> >>
> >>
> >> On 2021/5/5 0:12, Ulf Hansson wrote:
> >>> In SD spec v4.x the SD function extension registers were introduced. A
> >>
> >> I have a v4.0 spec and it doesn't state that v4.0 suppports reading
> >> extension registers but just says TBD instead. So I guess v4.x doesn't
> >> include v4.0 ?
> >
> > Good question. The v4.0 spec introduces the CMD48/49 and CMD58/59,
> > while in v4.10 the spec adds the power management extensions.
> >
> > I can update the commit message to better reflect this, if you prefer!?
>
> It would be better.

Sure, let me amend the change when applying.

>
> And I downloaded the latest v8.00 spec, checked carefully with the new
> features there to make sure we don't make any misinterpretations at
> first.
>
> For patch 9 -11 as well,
>
> Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

Thanks!

[...]

Kind regards
Uffe