Re: [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI

[Pavel Machek]

Hi!
On Wed 2021-05-05 16:22:07, Andy Shevchenko wrote:
> On Wed, May 5, 2021 at 11:36 AM Jonathan Cameron
> <Jonathan.Cameron@xxxxxxxxxx> wrote:
> > On Wed, 5 May 2021 09:32:35 +0100
> > Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote:
> > > On Tue, 4 May 2021 11:00:52 -0700
> > > Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> 
> +Cc: Paul (I hope you are related to coreboot somehow and can
> communicate this further), Pavel and Jacek (LED subsystem suffered
> with this as well), Hans, Rafael and linux-acpi@

Thanks for Cc. I prefer @ucw.cz address for the LED work.

> > > Dropping the ones we are fairly sure are spurious is even better!
> >
> > If I get bored I'll just do a scrub of all the instances of this that
> > you haven't already cleaned up.  It's worth noting that we do
> > know some highly suspicious looking entries are out there in the wild.
> 
> I have counted ~60 users of acpi_device_id in IIO. Brief looking at
> the IDs themselves rings an alarm about half of them.

As far as I can tell, this means asking "is this real ID or did you
just invent it" at patch submission. Okay...

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: Digital signature