Re: [PATCH v7 1/7] MAINTAINERS: Add Advantech AHC1EC0 embedded controller entry

From: Campion Kang
Date: Fri May 07 2021 - 08:04:11 EST


>-----Original Message-----
>From: Rob Herring <robh@xxxxxxxxxx>
>Sent: Friday, May 7, 2021 8:50 AM
>Subject: Re: [PATCH v7 1/7] MAINTAINERS: Add Advantech AHC1EC0
>embedded controller entry
>
>On Thu, May 06, 2021 at 10:47:22AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> I'm replying here since this series has no cover-letter, for
>> the next version for a series touching so many different
>> sub-systems it would be good to start with a cover-letter
>> providing some background info on the series.
>>
>> I see this is binding to an ACPI device, yet it is also using
>> devicetree bindings and properties.
>>
>> So I take it this means that your ACPI tables are using the
>> optional capability of embedded device-tree blobs inside the
>> ACPI tables ?
>
>Ugg, really. I would have stopped caring if I had realized.

I am very grateful for any comments you have made in the past, and please feel free to give friendly guidance.