Re: [PATCH] debugfs: fix security_locked_down() call for SELinux
From: Greg Kroah-Hartman
Date: Fri May 07 2021 - 08:16:11 EST
On Fri, May 07, 2021 at 01:12:18PM +0100, Matthew Wilcox wrote:
> On Fri, May 07, 2021 at 02:03:04PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 07, 2021 at 01:41:50PM +0200, Ondrej Mosnacek wrote:
> > > Make sure that security_locked_down() is checked last so that a bogus
> > > denial is not reported by SELinux when (ia->ia_valid & (ATTR_MODE |
> > > ATTR_UID | ATTR_GID)) is zero.
> >
> > Why would this be "bogus"?
>
> I presume selinux is logging a denial ... but we don't then actually
> deny the operation.
That would be nice to note here...