Re: [PATCH] bluetooth: fix potential gfp

From: Johan Hovold
Date: Fri May 07 2021 - 09:11:31 EST


On Fri, May 07, 2021 at 10:27:39AM +0200, Marcel Holtmann wrote:
> Hi Pavel,
>
> > In qca_power_shutdown() qcadev local variable is
> > initialized by hu->serdev.dev private data, but
> > hu->serdev can be NULL and there is a check for it.
> >
> > Since, qcadev is not used before
> >
> > if (!hu->serdev)
> > return;
> >
> > we can move its initialization after this "if" to
> > prevent gfp.
> >
> > Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
> > ---
> > drivers/bluetooth/hci_qca.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> patch has been applied to bluetooth-next tree.

Why did you pick the v1 when it is clear from thread that a v2 has been
posted?

Johan