Re: [PATCH 1/3] mm/gup_benchmark: Support threading

From: Peter Xu
Date: Fri May 07 2021 - 10:04:21 EST


On Thu, May 06, 2021 at 09:37:37PM -0700, John Hubbard wrote:
> On 5/6/21 4:25 PM, Peter Xu wrote:
> > Add a new parameter "-j N" to support concurrent gup test.
>
> I had a long-standing personal TODO item that said, "decide if it's
> worth it, to add pthread support to gup_test". So now, at least one
> other person has decided that it *is* worth it, and you've also written
> the patch. OK, then. Sweet! :)
>
> This looks correct to me. I have a couple of minor comments below, but
> either way you can add:

I'll address them.

>
> Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>

Thanks!

--
Peter Xu