Re: [PATCH] usb: dwc3: gadget: Return success always for kick transfer in ep queue

From: Wesley Cheng
Date: Fri May 07 2021 - 13:39:20 EST




On 5/7/2021 5:34 AM, Felipe Balbi wrote:
> Wesley Cheng <wcheng@xxxxxxxxxxxxxx> writes:
>
>> If an error is received when issuing a start or update transfer
>> command, the error handler will stop all active requests (including
>> the current USB request), and call dwc3_gadget_giveback() to notify
>> function drivers of the requests which have been stopped. Avoid
>> returning an error for kick transfer during EP queue, to remove
>> duplicate cleanup operations on the request being queued.
>>
>> Signed-off-by: Wesley Cheng <wcheng@xxxxxxxxxxxxxx>

Hi Felipe,
>
> do you want to add a Fixes here? :-)
>
Sure, will do!

> We should probably Cc stable too.
>
Got it.

Thanks
Wesley Cheng

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project